Improve game detection when Roman numerals are involved - #137
Draft
YetAnotherGerrit wants to merge 1 commit into
Draft
Improve game detection when Roman numerals are involved#137YetAnotherGerrit wants to merge 1 commit into
YetAnotherGerrit wants to merge 1 commit into
Conversation
Author
|
Not sure, if that is a "solution" that fits your style @JustTemmie - feel free to reject if to janky :-) |
YetAnotherGerrit
marked this pull request as draft
May 29, 2026 06:36
Author
|
Converted to draft, because I want to spend more time testing/trying to break it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132 by improving the game detection when the Discord game name contains Roman numerals while the Steam game name does not.